mirror of
https://github.com/go-gitea/gitea.git
synced 2026-06-17 19:10:22 +03:00
bircni
68692e19d4
- Enforce org visibility on organization label read endpoints (private org labels no longer leak to non-members). - Block fork sync (`merge-upstream`) when the base repo is no longer readable (stops pulling commits after a parent goes private). - Remove `REVERSE_PROXY_LIMIT` / `REVERSE_PROXY_TRUSTED_PROXIES` from the Docker `app.ini` templates (the `= *` default allowed `X-WEBAUTH-USER` impersonation; reverse-proxy auth is now opt-in and admin-configured). - Enforce single-use TOTP passcodes across web login, password-reset, and Basic-Auth `X-Gitea-OTP` (fixes a TOCTOU race and a stateless replay). - Re-check branch write permission for every ref in a push (the pre-receive hook cached the first ref's result, letting a per-branch maintainer-edit grant escalate to full repo write). --------- Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
112 lines
3.5 KiB
Go
112 lines
3.5 KiB
Go
// Copyright 2023 The Gitea Authors. All rights reserved.
|
|
// SPDX-License-Identifier: MIT
|
|
|
|
package integration
|
|
|
|
import (
|
|
"net/http"
|
|
"testing"
|
|
"time"
|
|
|
|
auth_model "gitea.dev/models/auth"
|
|
"gitea.dev/models/unittest"
|
|
user_model "gitea.dev/models/user"
|
|
"gitea.dev/tests"
|
|
|
|
"github.com/pquerna/otp/totp"
|
|
"github.com/stretchr/testify/assert"
|
|
)
|
|
|
|
func TestAPITwoFactor(t *testing.T) {
|
|
defer tests.PrepareTestEnv(t)()
|
|
|
|
user := unittest.AssertExistsAndLoadBean(t, &user_model.User{ID: 16})
|
|
|
|
req := NewRequest(t, "GET", "/api/v1/user").
|
|
AddBasicAuth(user.Name)
|
|
MakeRequest(t, req, http.StatusOK)
|
|
|
|
otpKey, err := totp.Generate(totp.GenerateOpts{
|
|
SecretSize: 40,
|
|
Issuer: "gitea-test",
|
|
AccountName: user.Name,
|
|
})
|
|
assert.NoError(t, err)
|
|
|
|
tfa := &auth_model.TwoFactor{
|
|
UID: user.ID,
|
|
}
|
|
assert.NoError(t, tfa.SetSecret(otpKey.Secret()))
|
|
|
|
assert.NoError(t, auth_model.NewTwoFactor(t.Context(), tfa))
|
|
|
|
req = NewRequest(t, "GET", "/api/v1/user").
|
|
AddBasicAuth(user.Name)
|
|
MakeRequest(t, req, http.StatusUnauthorized)
|
|
|
|
passcode, err := totp.GenerateCode(otpKey.Secret(), time.Now())
|
|
assert.NoError(t, err)
|
|
|
|
req = NewRequest(t, "GET", "/api/v1/user").
|
|
AddBasicAuth(user.Name)
|
|
req.Header.Set("X-Gitea-OTP", passcode)
|
|
MakeRequest(t, req, http.StatusOK)
|
|
|
|
// the same passcode must not be replayable on the basic-auth surface (RFC 6238 single-use)
|
|
req = NewRequest(t, "GET", "/api/v1/user").
|
|
AddBasicAuth(user.Name)
|
|
req.Header.Set("X-Gitea-OTP", passcode)
|
|
MakeRequest(t, req, http.StatusUnauthorized)
|
|
}
|
|
|
|
func TestBasicAuthWithWebAuthn(t *testing.T) {
|
|
defer tests.PrepareTestEnv(t)()
|
|
|
|
// user1 has no webauthn enrolled, he can request API with basic auth
|
|
user1 := unittest.AssertExistsAndLoadBean(t, &user_model.User{ID: 1})
|
|
unittest.AssertNotExistsBean(t, &auth_model.WebAuthnCredential{UserID: user1.ID})
|
|
req := NewRequest(t, "GET", "/api/v1/user")
|
|
req.SetBasicAuth(user1.Name, "password")
|
|
MakeRequest(t, req, http.StatusOK)
|
|
|
|
// user1 has no webauthn enrolled, he can request git protocol with basic auth
|
|
req = NewRequest(t, "GET", "/user2/repo1/info/refs")
|
|
req.SetBasicAuth(user1.Name, "password")
|
|
MakeRequest(t, req, http.StatusOK)
|
|
|
|
// user1 has no webauthn enrolled, he can request container package with basic auth
|
|
req = NewRequest(t, "GET", "/v2/token")
|
|
req.SetBasicAuth(user1.Name, "password")
|
|
resp := MakeRequest(t, req, http.StatusOK)
|
|
|
|
type tokenResponse struct {
|
|
Token string `json:"token"`
|
|
}
|
|
tokenParsed := DecodeJSON(t, resp, &tokenResponse{})
|
|
assert.NotEmpty(t, tokenParsed.Token)
|
|
|
|
// user32 has webauthn enrolled, he can't request API with basic auth
|
|
user32 := unittest.AssertExistsAndLoadBean(t, &user_model.User{ID: 32})
|
|
unittest.AssertExistsAndLoadBean(t, &auth_model.WebAuthnCredential{UserID: user32.ID})
|
|
|
|
req = NewRequest(t, "GET", "/api/v1/user")
|
|
req.SetBasicAuth(user32.Name, "notpassword")
|
|
resp = MakeRequest(t, req, http.StatusUnauthorized)
|
|
|
|
type userResponse struct {
|
|
Message string `json:"message"`
|
|
}
|
|
userParsed := DecodeJSON(t, resp, &userResponse{})
|
|
assert.Equal(t, "basic authorization is not allowed while WebAuthn enrolled", userParsed.Message)
|
|
|
|
// user32 has webauthn enrolled, he can't request git protocol with basic auth
|
|
req = NewRequest(t, "GET", "/user2/repo1/info/refs")
|
|
req.SetBasicAuth(user32.Name, "notpassword")
|
|
MakeRequest(t, req, http.StatusUnauthorized)
|
|
|
|
// user32 has webauthn enrolled, he can't request container package with basic auth
|
|
req = NewRequest(t, "GET", "/v2/token")
|
|
req.SetBasicAuth(user1.Name, "notpassword")
|
|
MakeRequest(t, req, http.StatusUnauthorized)
|
|
}
|