Use modern WaitGroup.Go function in additional places

pkg/healthcheck/healthcheck_test.go

@@ -515,7 +515,6 @@ func TestDifferentIntervals(t *testing.T) {
 	wg := sync.WaitGroup{}
 	wg.Go(func() {
 		hc.Launch(ctx)
-		wg.Done()
 	})
 
 	select {

pkg/middlewares/auth/basic_auth_test.go

@@ -192,11 +192,9 @@ func TestBasicAuthConcurrentHashOnce(t *testing.T) {
 	defer ts.Close()
 
 	var wg sync.WaitGroup
-	wg.Add(2)
 
 	for range 2 {
-		go func() {
+		wg.Go(func() {
-			defer wg.Done()
 			req := testhelpers.MustNewRequest(http.MethodGet, ts.URL, nil)
 			req.SetBasicAuth("test", "test")
 
@@ -205,7 +203,7 @@ func TestBasicAuthConcurrentHashOnce(t *testing.T) {
 			defer res.Body.Close()
 
 			assert.Equal(t, http.StatusOK, res.StatusCode, "they should be equal")
-		}()
+		})
 	}
 
 	wg.Wait()

pkg/server/server_entrypoint_udp.go

@@ -51,8 +51,6 @@ func (eps UDPEntryPoints) Stop() {
 
 	for epn, ep := range eps {
 		wg.Go(func() {
-			defer wg.Done()
-
 			logger := log.With().Str(logs.EntryPointName, epn).Logger()
 			ep.Shutdown(logger.WithContext(context.Background()))
 

pkg/server/service/loadbalancer/leasttime/leasttime_test.go

@@ -560,13 +560,11 @@ func TestConcurrentResponseTimeUpdates(t *testing.T) {
 	updatesPerGoroutine := 20
 
 	for i := range numGoroutines {
-		wg.Add(1)
+		wg.Go(func() {
-		go func(id int) {
-			defer wg.Done()
 			for range updatesPerGoroutine {
-				handler.updateResponseTime(time.Duration(id+1) * time.Millisecond)
+				handler.updateResponseTime(time.Duration(i+1) * time.Millisecond)
 			}
-		}(i)
+		})
 	}
 
 	wg.Wait()