mirror of
https://github.com/go-gitea/gitea.git
synced 2026-06-17 19:10:22 +03:00
metsw24-max
0eba0e371f
**Unvalidated version in goproxy ParsePackage** The module version is read straight from the zip directory path and never checked, so a crafted upload can leave a newline in it; `EnumeratePackageVersions` then writes each stored version on its own line for the `@v/list` endpoint, letting a module advertise fabricated versions to `go` clients. Validated the parsed version with `semver.IsValid` inside the parser, matching the version checks the other package parsers already do. Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
104 lines
2.1 KiB
Go
104 lines
2.1 KiB
Go
// Copyright 2023 The Gitea Authors. All rights reserved.
|
|
// SPDX-License-Identifier: MIT
|
|
|
|
package goproxy
|
|
|
|
import (
|
|
"archive/zip"
|
|
"io"
|
|
"path"
|
|
"strings"
|
|
|
|
"gitea.dev/modules/util"
|
|
|
|
"golang.org/x/mod/semver"
|
|
)
|
|
|
|
const (
|
|
PropertyGoMod = "go.mod"
|
|
|
|
maxGoModFileSize = 16 * 1024 * 1024 // https://go.dev/ref/mod#zip-path-size-constraints
|
|
)
|
|
|
|
var (
|
|
ErrInvalidStructure = util.NewInvalidArgumentErrorf("package has invalid structure")
|
|
ErrInvalidVersion = util.NewInvalidArgumentErrorf("package version is invalid")
|
|
ErrGoModFileTooLarge = util.NewInvalidArgumentErrorf("go.mod file is too large")
|
|
)
|
|
|
|
type Package struct {
|
|
Name string
|
|
Version string
|
|
GoMod string
|
|
}
|
|
|
|
// ParsePackage parses the Go package file
|
|
// https://go.dev/ref/mod#zip-files
|
|
func ParsePackage(r io.ReaderAt, size int64) (*Package, error) {
|
|
archive, err := zip.NewReader(r, size)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
|
|
var p *Package
|
|
|
|
for _, file := range archive.File {
|
|
nameAndVersion := path.Dir(file.Name)
|
|
|
|
parts := strings.SplitN(nameAndVersion, "@", 2)
|
|
if len(parts) != 2 {
|
|
continue
|
|
}
|
|
|
|
versionParts := strings.SplitN(parts[1], "/", 2)
|
|
|
|
if p == nil {
|
|
p = &Package{
|
|
Name: strings.TrimSuffix(nameAndVersion, "@"+parts[1]),
|
|
Version: versionParts[0],
|
|
}
|
|
|
|
// the version is taken verbatim from the zip path and later written
|
|
// one per line into the @v/list proxy response, so it has to be a
|
|
// valid module version (no newlines or other stray characters)
|
|
if !semver.IsValid(p.Version) {
|
|
return nil, ErrInvalidVersion
|
|
}
|
|
}
|
|
|
|
if len(versionParts) > 1 {
|
|
// files are expected in the "root" folder
|
|
continue
|
|
}
|
|
|
|
if path.Base(file.Name) == "go.mod" {
|
|
if file.UncompressedSize64 > maxGoModFileSize {
|
|
return nil, ErrGoModFileTooLarge
|
|
}
|
|
|
|
f, err := archive.Open(file.Name)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
defer f.Close()
|
|
|
|
bytes, err := io.ReadAll(&io.LimitedReader{R: f, N: maxGoModFileSize})
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
|
|
p.GoMod = string(bytes)
|
|
|
|
return p, nil
|
|
}
|
|
}
|
|
|
|
if p == nil {
|
|
return nil, ErrInvalidStructure
|
|
}
|
|
|
|
p.GoMod = "module " + p.Name
|
|
|
|
return p, nil
|
|
}
|