mirror of
https://github.com/goauthentik/authentik.git
synced 2026-06-18 03:19:51 +03:00
Ken Sternberg
2eedae7011
## What Re-arranges where types are declared and how they’re accessed. In some cases, refine the types to provide stronger build-time guarantees. ## Why A lot of our stages use bits and pieces of types from a base state, from the executor, and in some cases from redundant sources. Union types are great for some things, but Typescript can get really hung up on passing a union type as a function parameter when there’s some low-level non-conformance across all the types in the union. Because OpenAPI doesn’t do abstractions, this commit introduces a `StageChallengeLike`, which abstracts all of the Challenge types, asserting that there is a unifying parent class that contains the minimum collection fields found across all challenges, and this lets us address the different challenge types and their corresponding components before worrying about refining the type for construction and deployment. On the other hand, sometimes you want to be able to assert that *all* of the member of a union correspond to some shape of data, and you can always use `Pick<>` on the FormChallenge type to assert that at build time. Other than that, this centralizes the types into locations in the codebase with well-known names.